Adds GCR example #31
Merged
Adds GCR example #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Waters <waters@me.com>
andrew-waters
force-pushed
the
example-gcr
branch
from
06eea0d to
13d7e7a
Compare
zappy-shu
reviewed
Apr 23, 2020
| ``` | ||
|
|
||
| The following will build the root Dockerfile, tag the image as `myorg/myrepository:latest`, log in to Google Container Registry using GitHub secrets (where `DOCKER_PASSWORD` is a [JSON key](https://cloud.google.com/container-registry/docs/advanced-authentication#json-key)), and push the image to the CGR repository `myorg/myrepository`: |
There was a problem hiding this comment.
I believe unless you specific tags: latest or tag_with_ref: true then the image will not actually be tagged as anything. This is something that should probably be fixed as defaulting to {repository}:latest would be the logical functionality. As it is though could you please correct the example
There was a problem hiding this comment.
Good spot. I've updated it now
Signed-off-by: Andrew Waters <waters@me.com>
andrew-waters
force-pushed
the
example-gcr
branch
from
a64044e to
4ca0e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example of using the action with GCR