Skip to content

Make tags mandatory, since omitting it doesn't really do what you'd expect #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make tags mandatory, since omitting it doesn't really do what you'd expect #49

wants to merge 1 commit into from

Conversation

MaxHorstmann
Copy link

Fixes #48 by making "tags" a required input.

@MaxHorstmann
Make tags mandatory, since omitting it doesn't really do what you'd e…
06a13bc 
…xpect

Signed-off-by: Max Horstmann <max.horstmann@gmail.com>
@MaxHorstmann
Copy link
Author

Per further discussion on #48, this isn't quite the right fix. Making tags mandatory would prevent usage of other tagging mechanisms such as tag_with_ref. Needs a different solution, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"tags" not required, but omitting it doesn't do what you'd expect
1 participant
@MaxHorstmann