dap: add stack traces to stopped threads #3260
Closed
+4,229
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
dap-stacktrace
branch
2 times, most recently
from
e84bd7e to
3acbaa4
Compare
jsternberg
force-pushed
the
dap-stacktrace
branch
5 times, most recently
from
7548136 to
21e9a5d
Compare
Adds a simple implementation of the debug adapter that supports the very basics of a debug adapter. It supports the launch request, the configuration done request, the creation of threads, stopping, resuming, and disconnecting from server. It does not support custom breakpoints, stack traces, or variable inspection yet. These are planned to be added in the future. It also does not support sending output through the debug adapter yet. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Stack traces show the first parent of each operation that was run to get to the current location. It shows either their custom name from the LLB or it will show the command name. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
dap-stacktrace
branch
from
21e9a5d to
94a2b57
Compare
|
Parts of this have been integrated with #3279. I'm going to close this as that other PR is more complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack traces show the first parent of each operation that was run to
get to the current location. It shows either their custom name from the
LLB or it will show the command name.