(refactoring) introduce monitor to manage containers events and application termination #12906

ndeloof · 2025-06-05T12:56:48Z

What I did
refactoring:

introduced monitor to dispatch container events and manage application termination
re-implemented cascade stop as a separate component, relying on event dispatch
re-implemented watchcontainer relying on event dispatch, removed from start and log
printer only focus on rendering application status, not trying to detect termination - uses explicit termination
removed useless pre-allocation of presenter (color) in printer. Will be set on first use.

improvement (2nd commit):
collecting start event, capture container's StartTime. This is used to collect logs using log API (we are too late to attach) and retrieve the very first logs. Tested using:

func main() {
        fmt.Println("Hello, World!")
        time.Sleep(10*time.Second)
}

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

…cation termination Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

glours

LGTM

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | minor | `v2.38.2` -> `v2.39.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.39.1`](https://github.com/docker/compose/releases/tag/v2.39.1) [Compare Source](docker/compose@v2.39.0...v2.39.1) #### What's Changed 🔧 Internal - Add info about models usage to OpenTelemetry spans by [@glours](https://github.com/glours) in docker/compose#13094 ⚙️ Dependencies - Bump compose-go to v2.8.1 by [@glours](https://github.com/glours) in docker/compose#13096 **Full Changelog**: docker/compose@v2.39.0...v2.39.1 ### [`v2.39.0`](https://github.com/docker/compose/releases/tag/v2.39.0) [Compare Source](docker/compose@v2.38.2...v2.39.0) #### What's Changed ##### ✨ Improvements - Add `--since` & `--until` flags to `events` command by [@jarqvi](https://github.com/jarqvi) in docker/compose#13030 - Feat(os): add FreeBSD support by [@atagtm](https://github.com/atagtm) in docker/compose#13036 - Add `--models` flag to `config` command by [@jarqvi](https://github.com/jarqvi) in docker/compose#13022 - Warn user `COMPOSE_BAKE=false` is deprecated by [@ndeloof](https://github.com/ndeloof) in docker/compose#13065 - Simpler stop UI by [@ndeloof](https://github.com/ndeloof) in docker/compose#13064 - Introduce build `provenance` and `sbom` attributes support by [@ndeloof](https://github.com/ndeloof) in docker/compose#13067 - Show build progress during watch rebuild by [@ndeloof](https://github.com/ndeloof) in docker/compose#13059 ##### 🐛 Fixes - Add dry-run support to bake build by [@glours](https://github.com/glours) in docker/compose#13042 - Keep containers attached on stop to capture termination logs by [@ndeloof](https://github.com/ndeloof) in docker/compose#13010 - Add default compose labels to images built from bake by [@glours](https://github.com/glours) in docker/compose#13049 - Fix report image name in bake result by [@principis](https://github.com/principis) in docker/compose#13047 - Don't run navigation menu if stdin isn't a terminal by [@ndeloof](https://github.com/ndeloof) in docker/compose#13054 - Monitor must watch events even when context is cancelled by [@ndeloof](https://github.com/ndeloof) in docker/compose#13062 - Force `plain` display mode if stdout isn't a terminal by [@ndeloof](https://github.com/ndeloof) in docker/compose#13074 - Do not pass user id on Windows system as engine is not able to handel it by [@glours](https://github.com/glours) in docker/compose#13080 - Forward git command error to user by [@ndeloof](https://github.com/ndeloof) in docker/compose#13084 - Use output registry when push true and load to docker store if not by [@glours](https://github.com/glours) in docker/compose#13085 ##### 🔧 Internal - Add a space character to separate the timestamp from the log message by [@xduugu](https://github.com/xduugu) in docker/compose#13038 - Fix the Helm bridge e2e tests after the latest update of the templates by [@glours](https://github.com/glours) in docker/compose#13053 - Introduce monitor to manage containers events and application termination by [@ndeloof](https://github.com/ndeloof) in docker/compose#12906 - Abstract model-cli commands execution with a model (pseudo) API by [@ndeloof](https://github.com/ndeloof) in docker/compose#13051 - Swarm by [@ndeloof](https://github.com/ndeloof) in docker/compose#13071 - Remove uses of `moby/errdefs` by [@thaJeztah](https://github.com/thaJeztah) in docker/compose#13076 - Use local copy of `pkg/system.IsAbs` by [@thaJeztah](https://github.com/thaJeztah) in docker/compose#13075 - Optimize ansiColorCode by replacing fmt.Sprintf with strings.Builder by [@suwakei](https://github.com/suwakei) in docker/compose#13091 - Eliminate magic number in init functions by [@suwakei](https://github.com/suwakei) in docker/compose#13090 - Integration of SetAttributes calls by [@suwakei](https://github.com/suwakei) in docker/compose#13089 ##### ⚙️ Dependencies - Bump engine and cli to `v28.3.2` by [@ndeloof](https://github.com/ndeloof) in docker/compose#13035 - Build(deps): bump github.com/spf13/pflag from `1.0.6` to `1.0.7` by [@dependabot](https://github.com/dependabot)\[bot] in docker/compose#13060 - Bump `compose-go` to version `v2.8.0` by [@glours](https://github.com/glours) in docker/compose#13082 - Build(deps): bump google.golang.org/grpc from `1.73.0` to `1.74.2` by [@dependabot](https://github.com/dependabot)\[bot] in docker/compose#13081 - bump buildx to `v0.26.1` by [@glours](https://github.com/glours) in docker/compose#13086 #### New Contributors - [@atagtm](https://github.com/atagtm) made their first contribution in docker/compose#13036 - [@xduugu](https://github.com/xduugu) made their first contribution in docker/compose#13038 - [@principis](https://github.com/principis) made their first contribution in docker/compose#13047 - [@suwakei](https://github.com/suwakei) made their first contribution in docker/compose#13091 **Full Changelog**: docker/compose@v2.38.2...v2.39.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

ndeloof force-pushed the refactoring_events branch 10 times, most recently from 38f188f to a1a3ba1 Compare June 12, 2025 09:23

ndeloof force-pushed the refactoring_events branch 2 times, most recently from 4725733 to 842aad6 Compare June 12, 2025 13:50

ndeloof marked this pull request as ready for review June 12, 2025 15:07

ndeloof requested a review from a team as a code owner June 12, 2025 15:07

ndeloof requested a review from glours June 12, 2025 15:07

ndeloof force-pushed the refactoring_events branch from 842aad6 to 4830d0a Compare June 12, 2025 15:07

ndeloof mentioned this pull request Jun 17, 2025

pkg/compose: remove uses of ExecOptions.Detach #12950

Merged

ndeloof force-pushed the refactoring_events branch from 4830d0a to fa1bc3c Compare June 17, 2025 15:16

ndeloof force-pushed the refactoring_events branch from fa1bc3c to 017e1e8 Compare July 1, 2025 07:22

ndeloof added 2 commits July 15, 2025 14:45

(refactoring) introduce monitor to manage containers events and appli…

889435a

…cation termination Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

use logs API with Since to collect the very first logs after restart

d3551ad

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

ndeloof force-pushed the refactoring_events branch from 017e1e8 to d3551ad Compare July 15, 2025 13:23

glours approved these changes Jul 16, 2025

View reviewed changes

glours merged commit 1c37f1a into docker:main Jul 16, 2025
50 of 51 checks passed

BrewTestBot mentioned this pull request Jul 24, 2025

docker-compose 2.39.0 Homebrew/homebrew-core#231091

Merged

renovate bot mentioned this pull request Jul 24, 2025

Bump dependencies gitfool/cake-docker#141

Open

1 task

rancherbot mentioned this pull request Jul 25, 2025

rddepman: bump dockerCompose from 2.38.2 to 2.39.1 rancher-sandbox/rancher-desktop#8992

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(refactoring) introduce monitor to manage containers events and application termination #12906

(refactoring) introduce monitor to manage containers events and application termination #12906

Uh oh!

ndeloof commented Jun 5, 2025 •

edited

Loading

Uh oh!

glours left a comment

Uh oh!

Uh oh!

Uh oh!

(refactoring) introduce monitor to manage containers events and application termination #12906

(refactoring) introduce monitor to manage containers events and application termination #12906

Uh oh!

Conversation

ndeloof commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

glours left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ndeloof commented Jun 5, 2025 •

edited

Loading