Skip to content

move run logic inside backend #12908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

move run logic inside backend #12908

merged 2 commits into from
Jun 13, 2025

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jun 6, 2025

What I did
refactored run so that all the container management logic is owned by backend
added support for use_api_socket as a syntaxic sugar, adding bind/config resources to compose model, the same way it is implemented as experimental by docker/cli#5858 (waiting for actual support by Docker Engine)

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@ndeloof ndeloof requested a review from a team as a code owner June 6, 2025 07:49
@ndeloof ndeloof requested a review from glours June 6, 2025 07:49
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 38.38384% with 61 lines in your changes missing coverage. Please review.

Project coverage is 53.20%. Comparing base (60256a8) to head (3dcbec7).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/compose/apiSocket.go 11.53% 45 Missing and 1 partial ⚠️
pkg/compose/run.go 66.66% 8 Missing and 4 partials ⚠️
pkg/compose/create.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12908      +/-   ##
==========================================
- Coverage   53.39%   53.20%   -0.20%     
==========================================
  Files         160      161       +1     
  Lines       16542    16696     +154     
==========================================
+ Hits         8833     8883      +50     
- Misses       6800     6898      +98     
- Partials      909      915       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ndeloof ndeloof force-pushed the use-api-socket branch 2 times, most recently from 7af6eb8 to 3b848c3 Compare June 12, 2025 15:51
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ndeloof added 2 commits June 13, 2025 14:31
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof enabled auto-merge (rebase) June 13, 2025 12:32
@ndeloof ndeloof merged commit 9a5fa05 into docker:main Jun 13, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants