Merge pull request #315 from docker/compose-offset-completion-fix

Fix offset calculation issue when calculating Compose suggestions

Author: rcjsuen

CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable changes to the Docker Language Server will be documented in this file.
 
+## [Unreleased]
+
+### Fixed
+
+- Compose
+  - textDocument/completion
+    - fix error case triggered by using code completion before the first node ([#314](https://github.com/docker/docker-language-server/issues/314))
+
 ## [0.11.0] - 2025-06-10
 
 ### Added

internal/compose/completion.go

@@ -206,6 +206,9 @@ func Completion(ctx context.Context, params *protocol.CompletionParams, manager
 	character := int(params.Position.Character) + 1
 	path := constructCompletionNodePath(file, line)
 	if len(path) == 0 {
+		if topLevelNodeOffset != -1 && params.Position.Character != uint32(topLevelNodeOffset) {
+			return nil, nil
+		}
 		return &protocol.CompletionList{Items: createTopLevelItems()}, nil
 	} else if len(path) == 1 {
 		return nil, nil
@@ -570,6 +573,8 @@ func NodeStructure(line int, rootNodes []*ast.MappingValueNode) []*ast.MappingVa
 			candidate = node
 		} else if node.GetToken().Position.Line == line {
 			return []*ast.MappingValueNode{node}
+		} else if candidate == nil {
+			return []*ast.MappingValueNode{}
 		} else {
 			break
 		}

internal/compose/completion_test.go

@@ -2559,6 +2559,20 @@ services:
 			character: 0,
 			list:      nil,
 		},
+		{
+			name:      "completion is on a line before the first node and after it positionally",
+			content:   " \nservices:",
+			line:      0,
+			character: 1,
+			list:      nil,
+		},
+		{
+			name:      "completion is on a line before the first node and before it positionally",
+			content:   " \n  services:",
+			line:      0,
+			character: 1,
+			list:      nil,
+		},
 	}
 
 	composeFileURI := fmt.Sprintf("file:///%v", strings.TrimPrefix(filepath.ToSlash(filepath.Join(os.TempDir(), "compose.yaml")), "/"))