Skip to content

fix: highlighting in code blocks #22836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sarahsanders-docker
Copy link
Collaborator

Description

  • Highlighted lines for code blocks in dark mode are not rendering correctly

Related issues or tickets

https://docker.atlassian.net/browse/ENGDOCS-2731

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Jun 13, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 0dcbbb5
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/685027dd09b10500083ddf5d
😎 Deploy Preview https://deploy-preview-22836--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@craig-osterhout
Copy link
Contributor

I initially only checked https://deploy-preview-22836--docsdocker.netlify.app/build/checks/#fail-build-on-check-violations, and it looks readable.

Looking at others like this one, with white on light gray, is hard to read.
https://deploy-preview-22836--docsdocker.netlify.app/guides/php/develop/#add-phpmyadmin-to-interact-with-the-database

@sarahsanders-docker sarahsanders-docker merged commit a4d2113 into docker:main Jun 16, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants