Skip to content

Allow setting controller image version via env #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

p1-0tr
Copy link
Member

@p1-0tr p1-0tr commented Jun 13, 2025

During testing, or as an occasional workaround, it would be useful to specify a model-runner controller image version. So, add the ability to supply it via an environment variable.

@p1-0tr p1-0tr requested review from xenoscopic and doringeman June 13, 2025 09:40
Copy link
Contributor

@xenoscopic xenoscopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to ensure that we have a non-empty tag, we should check that version is non-empty too (it could be present but empty).

During testing, or as an occasional workaround, it would be useful to
specify a model-runner controller image version. So, add the ability to
supply it via an environment variable.

Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@docker.com>
@p1-0tr p1-0tr force-pushed the ps-controller-image-version branch from edd23d2 to acb2dfd Compare June 16, 2025 09:21
@p1-0tr p1-0tr merged commit b7339bc into main Jun 16, 2025
6 checks passed
@p1-0tr p1-0tr deleted the ps-controller-image-version branch June 16, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants