scheduler: move OpenAI recording after runner load/release #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the runner is defunct, then
loader.load
will evict it, which means it'll also remove the recorded OpenAI requests/responses for that model. Hence, record the request afterloader.load
returns so it doesn't get removed in the loading process.Without this patch, following these steps will result in a lost pair of request-response, the first one after the runner exited/was killed and had to be evicted because it was defunct.