Include the extension's name in all diagnostics #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there are other Docker and YAML extensions, including the Docker DX name in our diagnostics will help our users easily tell which diagnostics are coming from us and which diagnostics are not. Signed-off-by: Remy Suen <remy.suen@docker.com>
Signed-off-by: Remy Suen <remy.suen@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
As there are other Docker and YAML extensions, users are unable to tell which extension is contributing which diagnostic when they look at the Problems pane.
Proposed Solution
Including the Docker DX name in our diagnostics will help our users easily tell which diagnostics are coming from us and which diagnostics are not.
Fixes #127.
Proof of Work