Implement battery group mode in HomeWizard #146770
Merged
+540
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
DCSBL
commented
Jun 13, 2025
Comment on lines
+44
to
+48
| except UnauthorizedError as ex: | ||
| raise HomeAssistantError( | ||
| translation_domain=DOMAIN, | ||
| translation_key="api_unauthorized", | ||
| ) from ex |
There was a problem hiding this comment.
Actual handing of this case is done by coordinator (raises a repair)
| } | ||
| }, | ||
| "exceptions": { | ||
| "api_disabled": { | ||
| "message": "The local API is disabled." | ||
| }, | ||
| "api_unauthorized": { | ||
| "message": "The local API is unauthorized. Restore API access by following the instructions in the repair issue." |
There was a problem hiding this comment.
Can we have a better refer?
joostlek
requested changes
Jun 16, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
DCSBL
commented
Jun 17, 2025
NoRi2909
reviewed
Jun 17, 2025
|
@joostlek, I think this PR is ready for another review, but first, can you see why the check fails? |
joostlek
approved these changes
Jun 20, 2025
joostlek
changed the title
hanwg
pushed a commit
to hanwg/core
that referenced
this pull request
Jun 21, 2025
* Implement battery group mode for HomeWizard P1 * Clean up test * Disable 'entity_registry_enabled_default' * Fix failing tests because of 'entity_registry_enabled_default' * Proof entities are disabled by default * Undo dev change * Update homeassistant/components/homewizard/select.py * Update homeassistant/components/homewizard/select.py Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Update homeassistant/components/homewizard/strings.json * Apply suggestions from code review * Update tests due to updated translations --------- Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add support for Battery Group Mode. This feature allows switching between different control modes. The P1 Meter controls the group of batteries (or a battery), so the select is implemented for the P1 Meter.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: