Use non-autospec mock for Reolink's button tests #146969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial PR to completely drop autospec'ed mocks from Reolink. The reason is that autospec made the tests too slow, so the fixture scope was changed to 'module' in #125215 Having the fixture scope as 'module' makes the test methods spill over each other, which makes them fragile and more complex since they have to clean up the mock's state. I will update the remaining platform tests in followup PRs.
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: reolink
small-pr
|
Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
abmantis
commented
Jun 16, 2025
| @@ -62,6 +62,100 @@ def mock_setup_entry() -> Generator[AsyncMock]: | |||
| yield mock_setup_entry | |||
|
|
|||
|
|
|||
| def _init_host_mock(host_mock: MagicMock) -> None: | |||
There was a problem hiding this comment.
in the final PR, after removing everything that depends on autospec, I'll remove reolink_connect_class() and just move what's on this method to reolink_host().
starkillerOG
approved these changes
Jun 16, 2025
Running only the |
|
Perfect, lets wait for the CLI and then we can merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This is an initial PR to completely drop autospec'ed mocks from Reolink.
The reason is that autospec made the tests too slow, so the fixture scope was changed to 'module' in #125215
Having the fixture scope as 'module' makes the test methods spill over each other, which makes them fragile and more complex since they have to clean up the mock's state.
I will update the remaining platform tests in followup PRs.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: