-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
Remove deprecated support for lock sensors and corresponding actions in lcn #147143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated support for lock sensors and corresponding actions in lcn #147143
Conversation
ab262fd
to
95fc4d8
Compare
@@ -8,5 +8,5 @@ | |||
"documentation": "https://www.home-assistant.io/integrations/lcn", | |||
"iot_class": "local_push", | |||
"loggers": ["pypck"], | |||
"requirements": ["pypck==0.8.8", "lcn-frontend==0.2.5"] | |||
"requirements": ["pypck==0.8.8", "lcn-frontend==0.2.6"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we bump this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend allows you to configure the sensors that have now been removed. Accordingly, the frontend also had to be adapted.
I could put it in a separate PR if you prefer. I just thought that it was part of the changes in this PR.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
e3ce811
to
8128970
Compare
67323a8
to
c964579
Compare
42a441a
to
218e428
Compare
218e428
to
5354614
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes deprecated binary sensors for regulator locks and key locks in the LCN integration, simplifies entity registration, and bumps the lcn-frontend
dependency to the latest version.
- Drop
LcnRegulatorLockSensor
andLcnLockKeysSensor
(and related tests/snapshots/fixtures) - Simplify
add_lcn_entities
to only register generic binary sensors - Bump
lcn-frontend
to 0.2.6 in requirements andmanifest.json
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/components/lcn/test_binary_sensor.py | Removed tests targeting deprecated lock and key binary sensors |
tests/components/lcn/snapshots/test_binary_sensor.ambr | Pruned snapshots for removed lock/key sensors |
tests/components/lcn/fixtures/config_entry_pchk.json | Removed fixture entries for deprecated sensors |
requirements_test_all.txt | Updated lcn-frontend test dependency to 0.2.6 |
requirements_all.txt | Updated lcn-frontend runtime dependency to 0.2.6 |
homeassistant/components/lcn/manifest.json | Bumped lcn-frontend requirement to 0.2.6 |
homeassistant/components/lcn/binary_sensor.py | Deleted the two specialized lock sensor classes and streamlined entity setup |
Comments suppressed due to low confidence (1)
homeassistant/components/lcn/binary_sensor.py:30
- The new switch entities for regulator locks and key locks introduced to replace the deprecated binary sensors are not covered by any tests in this PR. Consider adding tests to verify that the switch entities are registered correctly and respond as expected to lock/unlock commands.
entities = [
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @alengwenus 👍
../Frenck
Breaking change
The binary sensors and actions for the lock states of regulators and the lock states of keys have been removed from the LCN integration. They have been replaced by the corresponding switch entities.
Proposed change
Support for binary sensors and the corresponding actions for the lock states of regulators and the lock states of keys have been marked deprecated in #35103.
Instead switch entities were added which also allow for setting the lock state.
Functionality for adding the binary sensor entities are removed from the LCN configuration frontend. For this the
lcn-frontend
package has to be bumped to the latest version:Release notes: https://github.com/alengwenus/lcn-frontend/releases
Code changes: alengwenus/lcn-frontend@0.2.5...0.2.6
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: