-
Notifications
You must be signed in to change notification settings - Fork 1
[PI Sprint 24/25 / PD-468] - [Feature] Add Hungarian Algorithm #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mbsaloka
wants to merge
7
commits into
master
Choose a base branch
from
feature/add-hungarian-algorithm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+483
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaaizHaikal
reviewed
May 2, 2025
include/keisan/hungarian.impl.hpp
Outdated
case 7: | ||
for (int row = 0; row < actual_size; ++row) { | ||
for (int col = 0; col < actual_size; ++col) { | ||
if (mask[row][col] == 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create enum for these constants to give better context?
enum class Mask {
NONE = 0,
STAR = 1,
PRIME = 2
};
FaaizHaikal
requested changes
May 3, 2025
include/keisan/hungarian.impl.hpp
Outdated
Comment on lines
242
to
257
if (row == -1 || col == -1) { | ||
step = 6; | ||
return; | ||
} else { | ||
mask[row][col] = PRIME; | ||
if (star_in_row(row)) { | ||
col = find_star_in_row(row); | ||
row_cover[row] = COVERED; | ||
col_cover[col] = UNCOVERED; | ||
} else { | ||
path_row_0 = row; | ||
path_col_0 = col; | ||
step = 5; | ||
return; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The else
block can be removed because the if
condition returns the function.
Suggested change
if (row == -1 || col == -1) { | |
step = 6; | |
return; | |
} else { | |
mask[row][col] = PRIME; | |
if (star_in_row(row)) { | |
col = find_star_in_row(row); | |
row_cover[row] = COVERED; | |
col_cover[col] = UNCOVERED; | |
} else { | |
path_row_0 = row; | |
path_col_0 = col; | |
step = 5; | |
return; | |
} | |
} | |
if (row == -1 || col == -1) { | |
step = 6; | |
return; | |
} | |
mask[row][col] = PRIME; | |
if (!star_in_row(row)) { | |
path_row_0 = row; | |
path_col_0 = col; | |
step = 5; | |
return; | |
} | |
col = find_star_in_row(row); | |
row_cover[row] = COVERED; | |
col_cover[col] = UNCOVERED; |
FaaizHaikal
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link:
https://ichiro-its.atlassian.net/browse/PD-468
Description
Hungarian algorithm implementation, used for landmark matching in likelihood calculation within the MCL algorithm.
Type of Change
How Has This Been Tested?
Checklist:
feature/JIRA-ID-SHORT-DESCRIPTION
if has a JIRA ticketenhancement/SHORT-DESCRIPTION
if has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTION
if the change doesn't need to be tested (urgent)