Skip to content

Docs: Split CLI section into invenio and invenio-cli with detailed command descriptions #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Jun 11, 2025

❤️ Thank you for your contribution!

Description

Closes: #719

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

  • I'm aware of the code of conduct.
  • I've created logical separate commits and followed the commit message format.
  • I've targeted the master branch.
  • If this documentation change impacts the current release of InvenioRDM, I will backport it to the production branch following approval or indicate to a maintainer that it should be backported.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13 Samk13 force-pushed the feat-roles-cli-commands branch from 57155ba to dce42bf Compare June 11, 2025 15:37
Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(would close this)

@@ -330,6 +331,60 @@ having new patch-level versions of third-party Python packages break your build.

!!! error "Not yet supported"

## Roles commands
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we are not documenting the invenio command here. We only document the invenio-cli one. Those commands are called via the invenio command: e.g., invenio roles create ...

Copy link
Member Author

@Samk13 Samk13 Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, fair point, but from a user perspective, this is confusing. People running InvenioRDM don't care whether it's invenio or invenio-cli under the hood, they just want to know how to manage roles.
Since these commands are required to use core RDM functionality, they need to be documented somewhere in the RDM docs. If invenio CLI is the correct way, fine, let’s create a dedicated section like “invenio-cli and Invenio CLI” or similar sections and list the commands available.
Right now, it’s basically hidden.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we are not documenting the invenio command here. We only document the invenio-cli one. Those commands are called via the invenio command: e.g., invenio roles create ...

Looking again at the CLI section, the claim that it's an invenio-cli only section isn’t accurate. It already includes commands that are actually invenio commands for example, invenio shell and invenio rdm. So we’re already documenting invenio commands directly in the CLI section.
If we’re exposing them to users, it makes sense to document them consistently rather than exclude some arbitrarily. I’ve created a dedicated section for invenio commands, so we can add these there in a clean and consistent way.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups we shouldn't have put those there in the first place 😅 . The separate file as you have it is better.

@Samk13 Samk13 force-pushed the feat-roles-cli-commands branch 4 times, most recently from 6021ee9 to 7cbcbd7 Compare June 11, 2025 18:42
@Samk13
Copy link
Member Author

Samk13 commented Jun 11, 2025

@fenekku
I’ve added a new section under CLI in the docs: invenio-cli and invenio. Previously, we only had a page for invenio-cli.
Now there’s a dedicated place for all invenio commands with high-level explanations, and thanks to AI, I was able to fill in the rest of the commands :P
In my opinion, this gives us room to expand, e.g., documenting the new i18n command, what it does, and how to use it.

The reality is: both invenio-cli and invenio are now needed to manage a running instance. We shouldn't treat one as secondary or expect users to look elsewhere for core functionality. The split section reflects that.
WDYT?

Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes creating a separate reference for the invenio commands is better 👍 . Hopefully this doesn't turn out to be too much to maintain with changes to those over time (like the invenio-cli commands reference can sometimes be unmaintained).

I also did some updates to the CLI section as part of the reorg I think, so overall that part will be much better. Thanks!

(There is a whole history of invenio / invenio-cli background, but yes invenio has always been required to operate an instance, so even if it is an Invenio-framework level command, I do agree it makes sense for us to document it)

@@ -0,0 +1,502 @@
# Invenio CLI reference

The `invenio` tool provides application management and administration commands. These commands are executed within the application context and are used for managing users, roles, access permissions, and other application-level operations.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Ultimately I think this is probably ok, although ironically invenio is the framework, and InvenioRdm with invenio-cli is the application/instance. Maybe reprise suggested wording above at first (but my recommendation is not that great either 🤷 )

@Samk13 Samk13 force-pushed the feat-roles-cli-commands branch 6 times, most recently from 467eae2 to e8119d4 Compare June 12, 2025 19:14
@Samk13 Samk13 changed the title docs: add user roles management commands to CLI reference Docs: Split CLI section into invenio and invenio-cli with detailed command descriptions Jun 12, 2025
* docs: add user roles management commands to CLI reference
* auto generated using AI
* reorganize invenio commands into dedicated section
@Samk13 Samk13 force-pushed the feat-roles-cli-commands branch from e8119d4 to 5cadafb Compare June 16, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document group/role creation including user+permissions
2 participants