-
Notifications
You must be signed in to change notification settings - Fork 73
Docs: Split CLI section into invenio and invenio-cli with detailed command descriptions #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
57155ba
to
dce42bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(would close this)
docs/reference/cli.md
Outdated
@@ -330,6 +331,60 @@ having new patch-level versions of third-party Python packages break your build. | |||
|
|||
!!! error "Not yet supported" | |||
|
|||
## Roles commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we are not documenting the invenio
command here. We only document the invenio-cli
one. Those commands are called via the invenio
command: e.g., invenio roles create ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, fair point, but from a user perspective, this is confusing. People running InvenioRDM don't care whether it's invenio
or invenio-cli
under the hood, they just want to know how to manage roles.
Since these commands are required to use core RDM functionality, they need to be documented somewhere in the RDM docs. If invenio CLI is the correct way, fine, let’s create a dedicated section like “invenio-cli and Invenio CLI” or similar sections and list the commands available.
Right now, it’s basically hidden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we are not documenting the
invenio
command here. We only document theinvenio-cli
one. Those commands are called via theinvenio
command: e.g.,invenio roles create ...
Looking again at the CLI section, the claim that it's an invenio-cli
only section isn’t accurate. It already includes commands that are actually invenio commands for example, invenio shell and invenio rdm. So we’re already documenting invenio commands directly in the CLI
section.
If we’re exposing them to users, it makes sense to document them consistently rather than exclude some arbitrarily. I’ve created a dedicated section for invenio commands, so we can add these there in a clean and consistent way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups we shouldn't have put those there in the first place 😅 . The separate file as you have it is better.
6021ee9
to
7cbcbd7
Compare
@fenekku The reality is: both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes creating a separate reference for the invenio
commands is better 👍 . Hopefully this doesn't turn out to be too much to maintain with changes to those over time (like the invenio-cli
commands reference can sometimes be unmaintained).
I also did some updates to the CLI section as part of the reorg I think, so overall that part will be much better. Thanks!
(There is a whole history of invenio
/ invenio-cli
background, but yes invenio
has always been required to operate an instance, so even if it is an Invenio-framework level command, I do agree it makes sense for us to document it)
@@ -0,0 +1,502 @@ | |||
# Invenio CLI reference | |||
|
|||
The `invenio` tool provides application management and administration commands. These commands are executed within the application context and are used for managing users, roles, access permissions, and other application-level operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: Ultimately I think this is probably ok, although ironically invenio
is the framework, and InvenioRdm with invenio-cli
is the application/instance. Maybe reprise suggested wording above at first (but my recommendation is not that great either 🤷 )
467eae2
to
e8119d4
Compare
* docs: add user roles management commands to CLI reference * auto generated using AI * reorganize invenio commands into dedicated section
e8119d4
to
5cadafb
Compare
❤️ Thank you for your contribution!
Description
Closes: #719
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
master
branch.production
branch following approval or indicate to a maintainer that it should be backported.Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: