improvement(compat testing): Automatically load a second container when running cross-client compat e2e tests #24889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP and is not yet intended to be merged
Description
This PR ensures that a second container is always loaded when running cross-client compat tests. Additionally, it adds
skipSecondContainerLoad
toITestContainerConfig
which allows tests authors to disable this functionality.This PR leverages
skipSecondContainerLoad
in 4 test suites. Without that option, those test suites would fail since they were written with the assumption that only a single contianer would be loaded.Test Runtime Increase
On a codespaces instance, I ran
time pnpm test
from thetest-end-to-end-tests
package three times with and without the changes in this PR.We would need to re-test for more accurate/consistent results, but we can expect a small, but noticeable, increase in runtime.
Misc
AB#6826