Delay pass creation until time to run #1621
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
shaahji
force-pushed
the
shaahji/system
branch
2 times, most recently
from
50e7c70 to
8d49aed
Compare
Logic avoids instantiating a Pass unless it is to be run. To avoid instantiation, only FullPassConfig is passed around.
xiaoyu-work
reviewed
Mar 25, 2025
| pass_cls: Type[Pass] = olive_config.import_pass_module(full_pass_config.type) | ||
|
|
||
| config_dict = full_pass_config.to_json().get("config") or {} | ||
| for param, param_config in pass_cls.default_config(full_pass_config.accelerator).items(): |
There was a problem hiding this comment.
Little bit confused here, can we use full_pass_config.config to get pass config?
There was a problem hiding this comment.
But we need a dictionary here not an object of type BasePassConfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay pass creation until time to run
Logic avoids instantiating a Pass unless it is to be run. To avoid instantiation, only FullPassConfig is passed around.
Checklist before requesting a review
lintrunner -a(Optional) Issue link