Auto Optimizer #1801
Open
Auto Optimizer #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
devang-ml
approved these changes
Apr 28, 2025
devang-ml
requested changes
Apr 29, 2025
shaahji
force-pushed
the
shaahji/autoopt
branch
2 times, most recently
from
c280226 to
6dc0579
Compare
shaahji
force-pushed
the
shaahji/autoopt
branch
2 times, most recently
from
4b48cf0 to
a2ab5b8
Compare
shaahji
force-pushed
the
shaahji/autoopt
branch
2 times, most recently
from
7e093d2 to
393a904
Compare
devang-ml
reviewed
May 6, 2025
| "use_model_builder": true, | ||
| "train_data_config": "wikitext2_train", | ||
| "calibration_data_config": "transformer_token_dummy_data", | ||
| "accelerator": { "accelerator_type": "cpu", "execution_provider": "CPUExecutionProvider" }, |
There was a problem hiding this comment.
Can we just use the accelerator from the system ?
There was a problem hiding this comment.
Olive config can have multiple system defined especially for cases where passes can use a separate host. That would make choosing the accelerator ambiguous.
| return False | ||
|
|
||
| if accelerator_spec.execution_provider == "QNNExecutionProvider": | ||
| logger.info("QNNExecutionProvider doesn't support optimized model.") |
There was a problem hiding this comment.
Since peephole optimizations are EP independent, why do we need this check?
There was a problem hiding this comment.
This is carry forward from current auto-opt cli implementation.
Lines 320 to 322 in 59bfe00
xiaoyu-work
reviewed
May 6, 2025
shaahji
force-pushed
the
shaahji/autoopt
branch
7 times, most recently
from
0a7a890 to
3d7aaee
Compare
Redo auto-optimizer logic to simplify and use search engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto Optimizer
Redo auto-optimizer logic to simplify and use search engine.
Also, update the auto-opt CLI command to use AutoOptimizer.
Checklist before requesting a review
lintrunner -a(Optional) Issue link