SelfUpdater: Add --no-same-owner to tar invocation
#2785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having `tar` attempt to set the original owner and access times for files when extracting them as `root`. While not best practice on multi-user systems, single-user systems (such as Alpine, or a chroot user namespace) run all processes as `root`, and it is possible to get a `tar` on that system that will attempt to set e.g. `UID 1000` from a tarball when that doesn't make any sense. As the Azure Pipelines agent doesn't really care about file ownership in this case, this flag should be completely safe to set, and should have no effect outside of the cases where it is needed.
jtpetty
reviewed
Feb 12, 2020
It appears that `busybox tar` does not support `--no-same-owner`, so use `-o` instead.
|
It does indeed appear that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having
tarattempt to set the original owner and access times for files when extracting them asroot. While not best practice on multi-user systems, single-user systems (such as Alpine, or a chroot user namespace) run all processes asroot, and it is possible to get ataron that system that will attempt to set e.g.UID 1000from a tarball when that doesn't make any sense. As the Azure Pipelines agent doesn't really care about file ownership in this case, this flag should be completely safe to set, and should have no effect outside of the cases where it is needed.