Added retry on TFVC getSources step #3016
Conversation
|
|
| throw; | ||
| } | ||
| } | ||
| await Task.Delay(delay); |
There was a problem hiding this comment.
I think this approach will add retries to everything, not just TFVC operations. I think a better approach would be to handle this in the TFVC CLI manager. I already did this for gets, but if we need it in more operations it should be pretty easy to build off of my pr here - #2972
There was a problem hiding this comment.
Adding on this, were you able to repro the issue that users were facing?
I'm concerned that error was due to the naming of the workspace folder and if so a retry wouldn't work.
Let me know what you think.
There was a problem hiding this comment.
Error happens from time to time, wouldn't naming of the workspace problem cause failure constantly? Anyways, retry didn't work out. In the most recent agent the same error happens
There was a problem hiding this comment.
@shkiltos let's discuss offline, feel free to ping me
There was a problem hiding this comment.
@shkiltos to follow up, I don't think this is the right approach, I think we'd be better served handling this directly in the TFVC CLI Manager, rather than retrying everything
Number of Azure DevOps customers are facing connection issue while building tfvc project. They are getting 503 on getSources step. Added a retry on this step