Skip to content

Fix script variables execution #4096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 96 commits into
base: master
Choose a base branch
from
Draft

Fix script variables execution #4096

wants to merge 96 commits into from

Conversation

localconst
Copy link
Contributor

@localconst localconst commented Dec 18, 2022 •
edited
Loading

Changelog:

  • Moved ContainerOperationProvider to Container namespace
  • Skipped several vulnerable variables on recursive expanding stage
  • Added warnings for this variables to use env instead
  • Added optional shell type param for ExpandValues
  • Added unit tests
  • Updated context constructor for StepRunner tests
  • Formatting
  • Added AZP_EXPAND_VULNERABLE_VARIABLES knob allowing to expand vulnerable variables
  • Added AZP_IGNORE_VULNERABLE_SCRIPT_WARNING_MESSAGES allowing to ignore warning messages

Konstantin Tyukalov added 30 commits October 27, 2022 23:23
Update vars expanding
db708e9
Pass task name to expanding function
53fd90d
Add check in RecalculateExpanded for target vars
498f036
Refactor vars expanding impl
db1704a
Correct cmdline postfix
8abfb26
Fix recursive matching of next variables
b129703
Add check for script tasks
2cd9aec
Move & rename lists to constants
210a5bd
Rename dict with variables and add description
8bd9033
Add test for non-expanding of vulnerable vars
2012c9c
Add tests for varutil
22ba0fc
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
7b9c986 
…-agent into users/KonstantinTyukalov/Fix_script_variables_execution
Add new tests for variables expanding
2be52e4
Make prefixes suffixes maps per shell
31e6474
Add release environment variables
942a28a
Fix enum naming
88a41f7
Update variables expanding for cmd shell
4bb3c1c
Add & update tests for cmd
6440826
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
5e1ded5 
…-agent into users/KonstantinTyukalov/Fix_script_variables_execution
Add test case for cmd
f5ba603
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
00bc1a2 
…-agent into users/KonstantinTyukalov/Fix_script_variables_execution
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
d3abb04 
…-agent into users/KonstantinTyukalov/Fix_script_variables_execution
Use ConvertToEnvVariableFormat util
d3d4f86
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
59364bc 
…-agent into users/KonstantinTyukalov/Fix_script_variables_execution
Shorten variables names
48175cd
Add tracing logs
a89bb2b
Ignore case for task & variable names
2b9238e
Remove unused import
c1ce082
Fix test with ignoring case
1957de0
Add new test cases
a9def1d
merlynomsft
merlynomsft reviewed Dec 21, 2022
View reviewed changes
Konstantin Tyukalov and others added 27 commits December 22, 2022 15:56
Revert to substring
e772bf0
Update PublishTelemetry
e6d17b6 
Move telemetryData from method,
change call position
Add variables expanding warnings to telemetry
29ad610
Change the metric for expanding warnings to just counting
8470923
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
9463e86 
…-agent into users/KonstantinTyukalov/Fix_script_variables_execution
Make EnvVariableParts readonly
a6f6b78
Use knob engine for AZP_EXPAND_VULNERABLE_VARIABLES in ExecutionConte…
9a76dee 
…xt init
Change IgnoreScriptVariablesWarnings knob to experimental
c0a3ac1
Add AZP_ESCAPE_SPECIAL_CMD_CHARACTERS knob
c3795e6
@localconst
Merge branch 'master' into users/KonstantinTyukalov/Fix_script_variab…
5640a60 
…les_execution
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
01ec110 
…-agent into users/KonstantinTyukalov/Fix_script_variables_execution
Move telemetry initialization to separate method
70c96fe
Move to AsBooleanStrict && add comments
7bcc33f
Update EspaceSpecialCmdCharacters knob description
2b0943c
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
dce7455 
…-agent into users/KonstantinTyukalov/Fix_script_variables_execution
Remove unnecessary telemetry checks
db68341
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
9657c87 
…-agent into users/KonstantinTyukalov/Fix_script_variables_execution
Update variables naming
9044145
Move get of ExpandVulnerableVariables knob to separate method
29360c3
Change default flag value in vars constructor
7c5c0d7
Update knobs default values
39de949
Remove custom logic for cmd
5073254
Remove cmd knob
1c491c0
Get rid of specific cmd tests
5f915b1
Fix test
ce5e546
Remove extra comments
3587f51
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
3c43f78 
…-agent into users/KonstantinTyukalov/Fix_script_variables_execution
@localconst localconst marked this pull request as draft November 9, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlynomsft merlynomsft

@Roman-Shchukin Roman-Shchukin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@localconst @merlynomsft @Roman-Shchukin