Skip readonly variables in process handler #4174
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmapetr
approved these changes
Feb 28, 2023
merlynomsft
reviewed
Feb 28, 2023
|
|
||
| if (_readonlyEnvVariables.Contains(key, StringComparer.OrdinalIgnoreCase)) | ||
| { | ||
| return; |
There was a problem hiding this comment.
Consider: log an error (or at least a warning) when attempting to set a 'read-only variable'
There was a problem hiding this comment.
I'm not really sure we want to throw error or warning here, because customer or task owner didn't really control what variables will be. Here we get all the environment variables and process them from case to case
merlynomsft
reviewed
Feb 28, 2023
| string value = line.Substring(index + 1); | ||
|
|
||
| if (_readonlyEnvVariables.Contains(key, StringComparer.OrdinalIgnoreCase)) | ||
| { |
There was a problem hiding this comment.
Consider: use feature flag for this change + collect metrics to determine impact and effectiveness
LiliaSabitova
approved these changes
Feb 28, 2023
localconst
commented
Mar 1, 2023
| @@ -126,6 +129,8 @@ public async Task RunAsync() | |||
| { | |||
| // Format the command so the environment variables can be captured. | |||
| cmdExeArgs = $"/c \"{command} {arguments} && echo {OutputDelimiter} && set \""; | |||
|
|
|||
| _readonlyEnvVariables = Constants.Variables.ReadOnlyVariables.ConvertAll(var => VarUtil.ConvertToEnvVariableFormat(var)); | |||
There was a problem hiding this comment.
One point missed here - we shoud also collect runtime env variables.
we may get full list of readonly variables from the AZP_READONLY_ENV_VARIABLES implemented here: #4175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip read-only variables in process handler to fit design concept:
https://github.com/microsoft/azure-pipelines-yaml/blob/master/design/readonly-variables.md