Skip to content

Add an exponential backoff mechanism for obtaining tokens #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ivanduplenskikh
Copy link
Contributor

@ivanduplenskikh ivanduplenskikh commented Jun 10, 2025

Description: initOIDCToken now waits for waitedTime * retryCount in milliseconds to prevent inreliable failed responses

Related WI: AB#2275633

@ivanduplenskikh ivanduplenskikh requested review from manolerazvan and a team as code owners June 10, 2025 14:44
Copy link

@aaudzei aaudzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the retryCount unification is a breaking change so blocking the PR in its current state

Copy link

@aaudzei aaudzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion

Copy link
Contributor

@onetocny onetocny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider using FF as changes you have introduce are quite complex.

@ivanduplenskikh ivanduplenskikh force-pushed the users/iduplenksikh/2275633-add-exponential-backoff-mechanism branch from 9fa84ac to 521c567 Compare June 25, 2025 15:11
@microsoft microsoft deleted a comment from azure-pipelines bot Jun 26, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Jun 26, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Jun 26, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Jun 26, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Jun 26, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Jun 26, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Jun 26, 2025
@ivanduplenskikh ivanduplenskikh force-pushed the users/iduplenksikh/2275633-add-exponential-backoff-mechanism branch from 4f02056 to 4fa19c0 Compare June 26, 2025 09:49
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@onetocny onetocny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates. Feel free to skip my last suggested change.

@ivanduplenskikh
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivanduplenskikh
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivanduplenskikh ivanduplenskikh merged commit 42b8ad3 into main Jun 26, 2025
3 of 6 checks passed
@ivanduplenskikh ivanduplenskikh deleted the users/iduplenksikh/2275633-add-exponential-backoff-mechanism branch June 26, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants