-
Notifications
You must be signed in to change notification settings - Fork 49
Add an exponential backoff mechanism for obtaining tokens #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an exponential backoff mechanism for obtaining tokens #464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the retryCount
unification is a breaking change so blocking the PR in its current state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider using FF as changes you have introduce are quite complex.
9fa84ac
to
521c567
Compare
initOIDCToken now waits for waitedTime * retryCount in milliseconds to prevent inreliable failed responses
4f02056
to
4fa19c0
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updates. Feel free to skip my last suggested change.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description: initOIDCToken now waits for waitedTime * retryCount in milliseconds to prevent inreliable failed responses
Related WI: AB#2275633