Skip to content

bug(trace-viewer): Overflow with TabbedPane Component #36251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Zemotacqy
Copy link
Contributor

Closes: #33930

  • TabbedPane component now supports overflowMode param that automatically renders elements to a dropdown upon container resize.
  • This is a generic component that can be applied all other UIElements where TabbedPane is used. Ex: workbench sidebar as well, making the whole view responsive.

Before:

before.mp4

After:

after.mp4

Copy link
Contributor

github-actions bot commented Jun 9, 2025

Test results for "tests 1"

6 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [chromium-library] › library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @ubuntu-22.04-chromium-tip-of-tree
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:411:5 › screencast › should capture css transformation @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:433:5 › page screenshot › should take fullPage screenshots during navigation @webkit-ubuntu-22.04-node18

39357 passed, 820 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman requested a review from agg23 June 10, 2025 12:58
@Zemotacqy
Copy link
Contributor Author

Hey @agg23 , Did you get a chance to review this PR?
Thanks in advance!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Docking UI Mode control panel to right side defaults to bad truncation of text
1 participant