-
Notifications
You must be signed in to change notification settings - Fork 4.2k
chore: remove custom drag&drop implementation for chromium #36287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
43b505a
to
2a1469f
Compare
This comment has been minimized.
This comment has been minimized.
2a1469f
to
bb9a843
Compare
Test results for "tests 1"6 flaky39519 passed, 832 skipped Merge workflow run. |
Test results for "tests others"1 flaky22190 passed, 552 skipped Merge workflow run. |
Test results for "tests 2"1 fatal errors, not part of any test 133 flaky237764 passed, 9718 skipped Merge workflow run. |
Chromium implemented drag&drop support through
Input.dispatchMouseEvent
a while ago:A few changes in behavior:
dragover
event immediately. See theshould not send dragover on the first mousemove
test. This behavior is not specced, and support varies between browsers. However, this is technically a minor regression.press('Escape')
call now first cancels an ongoing drag in a separate protocol call. This is due to Chromium not implementing this functionality natively, and instead relying on OS for it. The effect is minimal, so we can keep the behavior.process.env.PLAYWRIGHT_LEGACY_DRAG_AND_DROP
opts into old behavior for now.