Skip to content

chore: make fetch progress "strict" #36318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jun 16, 2025

References #35987.

Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39377 passed, 822 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman requested a review from yury-s June 16, 2025 15:20
@dgozman dgozman added the CQ1 label Jun 18, 2025
Copy link
Contributor

Test results for "tests others"

22106 passed, 523 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 2"

1 fatal errors, not part of any test
7 failed
❌ [chromium-library] › library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-macos-latest
❌ [chromium-library] › library/emulation-focus.spec.ts:129:3 › should change focused iframe @msedge-dev-macos-latest
❌ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke @msedge-dev-macos-latest
❌ [chromium-library] › library/emulation-focus.spec.ts:129:3 › should change focused iframe @msedge-dev-ubuntu-22.04
❌ [webkit-library] › library/multiclient.spec.ts:107:1 › should receive viewport size changes @tracing-webkit
❌ [webkit-library] › library/browsercontext-proxy.spec.ts:67:3 › should send secure cookies to subdomain.localhost @webkit-headed-windows-latest
❌ [webkit-library] › library/browsercontext-proxy.spec.ts:67:3 › should send secure cookies to subdomain.localhost @webkit-windows-latest

114 flaky ⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1262:3 › should work with connectOverCDP @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:93:7 › cli codegen › should not lead to an error if html gets clicked @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @channel-chromium-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke @channel-chromium-macos-latest
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @channel-chromium-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @channel-chromium-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @channel-chromium-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @channel-chromium-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:939:7 › run-server › socks proxy › should proxy based on the pattern @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch.spec.ts:22:3 › should reject all promises when browser is closed @chrome-beta-macos-latest
⚠️ [chromium-library] › library/channels.spec.ts:235:1 › should work with the domain module @chrome-beta-macos-latest
⚠️ [chromium-library] › library/signals.spec.ts:78:7 › signals › should close the browser on SIGINT @chrome-beta-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke @chrome-macos-latest
⚠️ [chromium-library] › library/tracing.spec.ts:207:5 › should respect tracesDir and name @chrome-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @chrome-macos-latest
⚠️ [chromium-page] › page/page-drag.spec.ts:249:5 › Drag and drop › should work if the drag event is captured but not canceled @chromium-headed-windows-latest
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1312:1 › should pick locator in iframe @chromium-macos-14-large
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:222:7 › cli codegen › should generate frame locators (4) @chromium-macos-14-xlarge
⚠️ [chromium-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @chromium-tip-of-tree-macos-13--headed
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-beta-macos-latest
⚠️ [firefox-page] › page/page-event-request.spec.ts:182:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-beta-macos-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-beta-ubuntu-22.04
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @firefox-beta-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:36:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:274:3 › should work with offline option @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:55:3 › should format date @firefox-headed-windows-latest
⚠️ [firefox-library] › library/hit-target.spec.ts:244:3 › should not click iframe overlaying the target @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:891:7 › cli codegen › should record slider @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:549:7 › cli codegen › should generate getByAltText @firefox-headed-windows-latest
⚠️ [firefox-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-goto.spec.ts:147:3 › should work with Cross-Origin-Opener-Policy after redirect @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @firefox-windows-latest
⚠️ [firefox-library] › library/debug-controller.spec.ts:71:1 › should pick element @firefox-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1262:3 › should work with connectOverCDP @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:142:5 › launchServer › should be able to reconnect to a browser @msedge-beta-macos-latest
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:178:3 › should exclude patterns @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-storage-state.spec.ts:361:3 › should support IndexedDB @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:33:5 › launch server › should work with host @msedge-macos-latest
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-ubuntu-22.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox
⚠️ [firefox-library] › library/page-clock.spec.ts:264:3 › stubTimers › replaces global performance.now @tracing-firefox
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @tracing-webkit
⚠️ [webkit-library] › library/multiclient.spec.ts:119:1 › should not allow parallel js coverage and cleanup upon disconnect @tracing-webkit
⚠️ [webkit-library] › library/multiclient.spec.ts:154:1 › last emulateMedia wins @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit
⚠️ [webkit-page] › page/page-screenshot.spec.ts:433:5 › page screenshot › should take fullPage screenshots during navigation @tracing-webkit
⚠️ [webkit-page] › page/page-screenshot.spec.ts:565:7 › page screenshot › mask option › should hide elements based on attr @tracing-webkit
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:261:5 › post data › should amend utf8 post data @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:381:7 › cli codegen › should press @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should click button with nested div @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:473:7 › cli codegen › should fill tricky characters @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:737:7 › cli codegen › should assert value @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:120:7 › should show aria snapshot error @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:23:7 › should inspect locator @webkit-headed-windows-latest
⚠️ [webkit-library] › library/popup.spec.ts:258:3 › should not throw when click closes popup @webkit-headed-windows-latest
⚠️ [webkit-library] › library/tracing.spec.ts:430:14 › should produce screencast frames fit @webkit-macos-13-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:430:14 › should produce screencast frames scale @webkit-macos-13-xlarge
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-14-large
⚠️ [webkit-library] › library/tracing.spec.ts:430:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:430:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1312:1 › should pick locator in iframe @webkit-macos-15-large
⚠️ [webkit-page] › page/page-request-continue.spec.ts:218:5 › post data › should amend post data @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @webkit-ubuntu-24.04

236919 passed, 9466 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant