Skip to content

chore: make screenshot progress "strict" #36323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jun 16, 2025

References #35987.

Copy link
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node22
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-trace.spec.ts:587:5 › should indicate current test status @macos-latest-node18-1
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

39375 passed, 822 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman requested a review from yury-s June 16, 2025 15:20
@dgozman dgozman added the CQ1 label Jun 18, 2025
Copy link
Contributor

Test results for "tests others"

22112 passed, 523 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 2"

11 failed
❌ [chromium-library] › library/inspector/title.spec.ts:35:5 › should update primary page URL when original primary closes @channel-chromium-macos-latest
❌ [chromium-library] › library/browsertype-connect.spec.ts:427:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest
❌ [chromium-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @chrome-macos-latest
❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-beta-macos-latest
❌ [chromium-library] › library/emulation-focus.spec.ts:129:3 › should change focused iframe @msedge-dev-macos-latest
❌ [chromium-library] › library/emulation-focus.spec.ts:129:3 › should change focused iframe @msedge-dev-ubuntu-22.04
❌ [chromium-library] › library/emulation-focus.spec.ts:129:3 › should change focused iframe @msedge-dev-windows-latest
❌ [webkit-library] › library/multiclient.spec.ts:260:1 › should remove init scripts upon disconnect @tracing-webkit
❌ [webkit-page] › page/page-event-popup.spec.ts:28:3 › should work with window features @tracing-webkit
❌ [webkit-library] › library/browsercontext-proxy.spec.ts:67:3 › should send secure cookies to subdomain.localhost @webkit-headed-windows-latest
❌ [webkit-library] › library/browsercontext-proxy.spec.ts:67:3 › should send secure cookies to subdomain.localhost @webkit-windows-latest

139 flaky ⚠️ [chromium-library] › library/browsertype-connect.spec.ts:970:7 › run-server › socks proxy › should check proxy pattern on the client @channel-chromium-macos-latest
⚠️ [chromium-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently @channel-chromium-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:93:7 › cli codegen › should not lead to an error if html gets clicked @channel-chromium-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:146:3 › should work with authenticate followed by redirect @channel-chromium-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:228:3 › should use socks proxy @channel-chromium-macos-latest
⚠️ [chromium-page] › page/page-event-popup.spec.ts:96:3 › should work with noopener and about:blank @channel-chromium-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @channel-chromium-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @channel-chromium-macos-latest
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1350:1 › should highlight locator in iframe while typing @channel-chromium-ubuntu-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest
⚠️ [chromium-library] › library/channels.spec.ts:235:1 › should work with the domain module @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/title.spec.ts:35:5 › should update primary page URL when original primary closes @chrome-beta-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke @chrome-beta-macos-latest
⚠️ [chromium-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @chrome-beta-macos-latest
⚠️ [chromium-library] › library/signals.spec.ts:94:7 › signals › should close the browser on SIGHUP @chrome-beta-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:25:3 › Page.workers @smoke @chrome-beta-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @chrome-beta-macos-latest
⚠️ [chromium-library] › library/har.spec.ts:80:3 › should have pages in persistent context @chrome-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke @chrome-macos-latest
⚠️ [chromium-page] › page/page-drag.spec.ts:103:5 › Drag and drop › should cancel on escape @chromium-headed-windows-latest
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1312:1 › should pick locator in iframe @chromium-macos-14-large
⚠️ [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-macos-14-xlarge
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-tip-of-tree-headless-shell-ubuntu-22.04
⚠️ [chromium-library] › library/trace-viewer.spec.ts:471:1 › should show snapshot URL @chromium-tip-of-tree-ubuntu-22.04--headed
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-macos-latest
⚠️ [firefox-page] › page/page-event-request.spec.ts:182:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-beta-macos-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-ubuntu-22.04
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-beta-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-python.spec.ts:144:5 › should work with --save-har and --save-har-glob @firefox-beta-windows-latest
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-windows-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-beta-windows-latest
⚠️ [firefox-library] › library/browsercontext-fetch.spec.ts:1346:3 › should update host header on redirect @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-macos-14-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:36:3 › should be able to click across browser contexts @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:376:3 › should create two pages in parallel in various contexts @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-har.spec.ts:516:3 › context.unrouteAll should stop context.routeFromHAR @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:55:7 › cli codegen › should double click @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-large
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-macos-13-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-13-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-large
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-macos-14-large
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-24.04
⚠️ [firefox-library] › library/debug-controller.spec.ts:71:1 › should pick element @firefox-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-windows-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-windows-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1262:3 › should work with connectOverCDP @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:61:5 › launch server › should default to random wsPath @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:67:5 › launch server › should provide an error when ws endpoint is incorrect @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:105:5 › launch server › should log protocol @msedge-beta-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:160:5 › should connect to existing page with iframe and navigate @msedge-beta-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:413:5 › should use proxy with connectOverCDP @msedge-beta-macos-latest
⚠️ [chromium-library] › library/downloads-path.spec.ts:32:5 › downloads path › should keep downloadsPath folder @msedge-beta-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-beta-macos-latest
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke @msedge-beta-macos-latest
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-beta-macos-latest
⚠️ [chromium-library] › library/popup.spec.ts:258:3 › should not throw when click closes popup @msedge-beta-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @msedge-beta-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:441:5 › screencast › should work for popups @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:103:3 › should set cookie for top-level domain @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-beta-windows-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:86:1 › should reset serviceworker that hangs in importScripts @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss @msedge-dev-macos-latest
⚠️ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-dev-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:291:3 › should use SOCKS proxy for websocket requests @msedge-dev-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:150:3 › should report network activity @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-dev-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1262:3 › should work with connectOverCDP @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:173:5 › launchServer › should ignore page.pause when headed @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:970:7 › run-server › socks proxy › should check proxy pattern on the client @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:94:5 › launch server › should fire close event @msedge-macos-latest
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @msedge-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:207:5 › screencast › should continue recording main page after popup closes @msedge-macos-latest
⚠️ [chromium-page] › page/workers.spec.ts:271:3 › should support extra http headers @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:103:3 › should set cookie for top-level domain @msedge-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-ubuntu-22.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest
⚠️ [chromium-library] › library/permissions.spec.ts:244:5 › should be able to use the local-fonts API @msedge-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @tracing-firefox
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @tracing-webkit
⚠️ [webkit-library] › library/multiclient.spec.ts:119:1 › should not allow parallel js coverage and cleanup upon disconnect @tracing-webkit
⚠️ [webkit-library] › library/multiclient.spec.ts:154:1 › last emulateMedia wins @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:205:14 › element screenshot › element screenshot should work with a mobile viewport @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:289:14 › element screenshot › should restore viewport after page screenshot and timeout @tracing-webkit
⚠️ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @tracing-webkit
⚠️ [webkit-library] › library/video.spec.ts:475:5 › screencast › should scale frames down to the requested size @tracing-webkit
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:332:7 › cli codegen › should fill textarea @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:381:7 › cli codegen › should press @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:578:7 › cli codegen › should uncheck @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1312:1 › should pick locator in iframe @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:55:7 › cli codegen › should double click @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:199:7 › cli codegen › should work with TrustedTypes @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:684:7 › cli codegen › should await popup @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @webkit-headed-windows-latest
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1312:1 › should pick locator in iframe @webkit-macos-13-large
⚠️ [webkit-library] › library/tracing.spec.ts:430:14 › should produce screencast frames fit @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:430:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:430:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:261:5 › post data › should amend utf8 post data @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-macos-15-large
⚠️ [webkit-library] › library/tracing.spec.ts:430:14 › should produce screencast frames fit @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:430:14 › should produce screencast frames crop @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:430:14 › should produce screencast frames scale @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-windows-latest

249301 passed, 9795 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant