test: prevent indexeddb race conditions #36347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The PR adds aria snapshot checks to stabilize the IndexedDB test by waiting for log messages before capturing storage state.
- Added initial check for “Database initialised.” notification.
- Added post-click check for “Transaction completed: database modification finished.” notification.
Comments suppressed due to low confidence (1)
tests/library/browsercontext-storage-state.spec.ts:372
- [nitpick] Using a full aria snapshot match can be brittle. Consider targeting the specific notification text with
locator.waitFor()orexpect(locator).toHaveText()for a more focused and maintainable check.
await expect(page.locator('#notifications')).toMatchAriaSnapshot(`
| await page.getByLabel('Task title').fill('Pet the cat'); | ||
| await page.getByLabel('Hours').fill('1'); | ||
| await page.getByLabel('Mins').fill('1'); | ||
| await page.getByText('Add Task').click(); | ||
| await expect(page.locator('#notifications')).toMatchAriaSnapshot(` | ||
| - list: | ||
| - listitem: "Transaction completed: database modification finished." |
There was a problem hiding this comment.
The quotes around the notification text in the aria snapshot will be matched literally. Remove the surrounding quotes so the matcher reflects the actual list item content.
Suggested change
| - listitem: "Transaction completed: database modification finished." | |
| - listitem: Transaction completed: database modification finished. |
Copilot uses AI. Check for mistakes.
dgozman
approved these changes
Jun 18, 2025
Test results for "tests 1"1 failed 6 flaky39414 passed, 822 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fails on Firefox CI sometimes - my hunch is that it's a race condition where either:
Luckily, the test site already has a log available we can use to wait for both. Let's hope this helps.