Text : Added EllipsizeMode for tail and clip alignment #14660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle follow defaulty tail behaviour
acoates-ms
reviewed
Jun 4, 2025
vnext/Microsoft.ReactNative/Fabric/Composition/ParagraphComponentView.cpp
Outdated
Show resolved
Hide resolved
acoates-ms
reviewed
Jun 4, 2025
vnext/Microsoft.ReactNative/Fabric/Composition/ParagraphComponentView.cpp
Outdated
Show resolved
Hide resolved
acoates-ms
reviewed
Jun 5, 2025
| // Reset m_textLayout when ellipsizeMode changes | ||
| if (oldViewProps.paragraphAttributes.ellipsizeMode != newViewProps.paragraphAttributes.ellipsizeMode) { | ||
| m_textLayout = nullptr; | ||
| } | ||
| if (oldViewProps.paragraphAttributes.adjustsFontSizeToFit != newViewProps.paragraphAttributes.adjustsFontSizeToFit) { | ||
| m_requireRedraw = true; |
There was a problem hiding this comment.
Not related to this PR. But I think we need to reset the textlayout here, not just redraw.
There was a problem hiding this comment.
makes sense , let me create an issue for the same and add this fix.
acoates-ms
reviewed
Jun 5, 2025
vnext/Microsoft.ReactNative/Fabric/Composition/ParagraphComponentView.cpp
Outdated
Show resolved
Hide resolved
acoates-ms
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added EllipsizeMode for tail and clip, for head and middle the behaviour maps to default tail alignment of ellipsis.
DirectWrite does not natively support head and middle truncation in the same way it supports tail.
A custom implementation will be required for the same adding that to backlog.
Type of Change
Why
This PR adds functionality to a prop EllipsizeMode particular to windows, this prop is tightly coupled with numberOfLines and adjusts the text alignment based on the ellipsis mode.
Resolves [Add Relevant Issue Here]
#13111
What
Made changes to paragraph.cpp to reflect ellipsis depending on the EllipsizeMode prop, and updating the text layout, text alignment for the same.
Screenshots
Testing
tested in playground.
Changelog
Should this change be included in the release notes: indicate yes or no
yes
Add a brief summary of the change to use in the release notes for the next release.
Added EllipsizeMode for tail and clip , for head and middle the behaviour maps to default tail alignment of ellipsis.
Microsoft Reviewers: Open in CodeFlow