.Net: MEVD data type tests #12567
Merged
.Net: MEVD data type tests #12567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westey-m
reviewed
Jun 24, 2025
| @@ -28,7 +28,7 @@ protected override bool IsKeyPropertyTypeValid(Type type, [NotNullWhen(false)] o | |||
|
|
|||
| protected override bool IsDataPropertyTypeValid(Type type, [NotNullWhen(false)] out string? supportedTypes) | |||
| { | |||
| supportedTypes = "bool, string, int, long, float, double, decimal, string[]/List<string>"; | |||
| supportedTypes = "bool, string, int, long, float, double, string[]/List<string>"; | |||
There was a problem hiding this comment.
Can you send me a list of types we are adding/removing support for so that I can also update the docs?
There was a problem hiding this comment.
Hey, sorry it took so long to do this. I generally tried to avoid making changes in this PR (but rather only to add tests), but here are changes I did (hopefully I didn't miss anything):
- Pinecone: remove decimal
- Redis: remove bool
- SQL Server: add DateOnly
In addition, the tests caught various trivial missing stuff which I added, so various types which weren't fully supported before (especially in LINQ filters) should now work properly.
westey-m
approved these changes
Jun 24, 2025
markwallace-microsoft
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12505