Skip to content

Optimized concat with reduce #251382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimized concat with reduce #251382

wants to merge 1 commit into from

Conversation

Connormiha
Copy link
Contributor

The concat method creates a new collection each time based on the existing one. Using push in this case saves resources.

DhruvTheDev1
DhruvTheDev1 reviewed Jun 13, 2025
View reviewed changes
Copy link

@DhruvTheDev1 DhruvTheDev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaces repeated use of concat with push to avoid unnecessary array creations and improves memory efficiency.

@lszomoru lszomoru removed their assignment Jun 16, 2025
@dbaeumer dbaeumer assigned rebornix and unassigned dbaeumer Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhruvTheDev1 DhruvTheDev1 DhruvTheDev1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Connormiha @DhruvTheDev1 @rebornix @dbaeumer @lszomoru