Fix notebook sticky scroll headers appearing too late when scrolling #251416
+63
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When scrolling through a notebook, sticky scroll headers would appear too late or not at all. For example, a header in cell 0 would not be revealed as sticky until much later when scrolling through content under that header.
Root Cause
The
computeContent
function innotebookEditorStickyScroll.ts
was limited to searching for headers only within the visible range of cells. It would start looking fromvisibleRange.start - 1
and search forward, missing headers that were far above the viewport but still relevant to the current section.Solution
Modified the algorithm to search backwards from the first visible cell (
visibleRange.start
) to find the most recent header, instead of searching forward fromvisibleRange.start - 1
.Before:
After:
Testing
Added
test8
that reproduces the scenario where a header at cell 0 should be sticky when viewing cells 4-7, ensuring headers far from the viewport are properly detected.The fix is minimal and focused - it reduces code complexity (6 additions, 32 deletions) while addressing the core issue.
Fixes #251415.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.