Allow using arrays of strings as messages in package.nls.json #251513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using arrays of strings in
package.nls.json
files, which are automatically joined with newline characters during the build process. This makes maintaining multiline strings much easier and more readable.Problem
Currently, multiline strings in
package.nls.json
files must be written as single lines with explicit\n
escape sequences:This is difficult to read and maintain, especially for longer descriptions.
Solution
With this change, you can now use arrays of strings that are automatically joined with newlines:
Implementation
The changes are minimal and surgical:
NLSFormat
interface inbuild/lib/extensions.ts
to acceptstring[]
typetranslatePackageJSON
function to handle string arrays by joining with'\n'
Key Features
Testing
Added comprehensive test suite covering:
All tests pass and the implementation has been verified with real-world scenarios.
Fixes #203362.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.