Skip to content

fix a11y issues w chat diff buttons #251748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jun 17, 2025

  1. Make them keyboard focusable
  2. When focused, allow space or enter to open the file diff
  3. Set the proper role, button

fixes #250397
fixes #17563

demo.mov

@meganrogge meganrogge self-assigned this Jun 17, 2025
@meganrogge meganrogge added this to the June 2025 milestone Jun 17, 2025
@meganrogge meganrogge enabled auto-merge (squash) June 17, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diff tag are not reachable by keyboard
1 participant