-
Notifications
You must be signed in to change notification settings - Fork 33.2k
Restarting task should read the updated content #251755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -23,6 +25,38 @@ export const enum TaskErrors { | |||
UnknownError | |||
} | |||
|
|||
export class VerifiedTask { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to move this here for code layer!
Proof of testing both restarting on going task and re-running last task: restarting: rerunning last task: Screen.Recording.2025-06-18.at.12.31.14.PM.mov |
@anthonykim1 thanks for working on this! Can you test this on a longrunning task for which you get the notification "the task is already active" vs a single run task like the one in your gif? |
@meganrogge Thanks for reviewing! Yeah, actually I'm not sure why that notification didn't show up in the first gif (the one that prints for 30 second). Edit: Oh, wait I'm finally able to get the notification, but this only shows up sometimes when I re-run, not when I restart from command palette: Just found a bug where re-starting non-changed compile task leads to error, will investigate and fix! |
Resolves: #169267
Fixing two things in this PR: