Fix task restart to re-read updated tasks.json configuration #251759
Closed
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task is running and the user edits
tasks.json
, clicking "Restart Task" on the warning dialog was restarting the task with the old definition instead of reading the updated configuration fromtasks.json
.Problem
The
_restart()
method inabstractTaskService.ts
was reusing the existing task object instead of re-reading from the workspace configuration:This meant that any changes made to
tasks.json
while a task was running would be ignored during restart.Solution
Added a new
_findUpdatedTaskByIdentifier()
method that:_findWorkspaceTasks()
infrastructure to search current workspace configurationThe
_restart()
method now resolves the fresh task definition before running:Backward Compatibility
Fixes #169267.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.