test: add missing port=0 arg in test-debugger-extract-function-name #58977
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Jul 7, 2025
lpinca
approved these changes
Jul 7, 2025
dario-piotrowicz
force-pushed
the
dario/deflake-test-debugger-extract-function-name
branch
from
dde5c1a to
6464821
Compare
dario-piotrowicz
added
the
commit-queue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58977 +/- ##
==========================================
- Coverage 90.09% 90.07% -0.02%
==========================================
Files 641 641
Lines 188666 188666
Branches 37003 37008 +5
==========================================
- Hits 169970 169947 -23
- Misses 11402 11439 +37
+ Partials 7294 7280 -14 🚀 New features to boost your workflow:
|
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/58977 ✔ Done loading data for nodejs/node/pull/58977 ----------------------------------- PR info ------------------------------------ Title test: add missing port=0 arg in test-debugger-extract-function-name (#58977) Author Dario Piotrowicz <dario.piotrowicz@gmail.com> (@dario-piotrowicz) Branch dario-piotrowicz:dario/deflake-test-debugger-extract-function-name -> nodejs:main Labels Commits 1 - test: add missing port=0 arg in test-debugger-extract-function-name Committers 1 - Dario Piotrowicz <dario.piotrowicz@gmail.com> PR-URL: https://github.com/nodejs/node/pull/58977 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58977 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 06 Jul 2025 20:01:20 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58977#pullrequestreview-2994091269 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58977#pullrequestreview-2995176354 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/16153314450 |
nodejs-github-bot
added
the
commit-queue-failed
dario-piotrowicz
added
request-ci
github-actions
bot
removed
the
request-ci
dario-piotrowicz
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0992d28 |
dario-piotrowicz
deleted the
dario/deflake-test-debugger-extract-function-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
test-debugger-extract-function-namefile the inspector port is not set to0, this causes the test (at least on my machine) to consistently (always) fail when run with the python runner with any repeat value greater than 1:So I am making sure that the port is indeed set to
0solving the issue.Also the test has also been a bit flaky in the CI lately:
So hopefully this change should address the flakiness 🙂
However I am not completely sure, since I did try to run some stress tests on the file on main:
But unfortunately they didn't show any flakes, so it is hard to confirm with full confidence whether
or not my changes are also addressing the CI flakes or not 😕