Add collector for PCIe devices with link information #3339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am really interested in this feature to check PCIe health in our Kubernetes cluster. @SuperQ Sorry for involving you. Could you take a look at this PR ? If you are not the right person to ask, please connect to the person to ask. |
The link status of PCIe devices sometimes changes,
like link or speed downgrades, and devices disappear.
This patch collects PCIe devices' link infromation to detect such failures.
As a first step, this collector exports PCIe devices'
- Device information (vendor_id, device_id, etc.)
- Parent PCIe device (e.g. PCIe bridge, PCIe switch)
- Link status (max_link_{speed|width}, current_link_{speed|width})
Signed-off-by: Naoki MATSUMOTO <m.naoki9911@gmail.com>
Signed-off-by: Naoki MATSUMOTO <m.naoki9911@gmail.com>
|
I've created a procfs library update PR separately in order to also update the test fixtures. #3355 |
|
Thank you for releasing procfs v0.17.0 ! I also found my PR lacks the fixture test. |
|
I would just wait till the other PR is merged and rebase here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link status of PCIe devices sometimes changes, like link or speed downgrades, and devices disappear. This patch collects PCIe devices' link infromation to detect such failures.
As a first step, this collector exports PCIe devices'
This depends on prometheus/procfs#728
https://groups.google.com/g/prometheus-developers/c/0GJTs2OjvCs