-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add CredentialsProvider field to UniversalOptions #2927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hello @dcherubini, We are introducing a new |
@dcherubini the StreamingCredentialsProvider is added. Would you like to update this PR to add all credentials providers: Lines 68 to 84 in 86d418f
|
@htemelski-redis , @ofekshenawa I did push the needed changes here, let me know if you would like to me to address something else so we can merge this one. |
f47372b
to
a7e7707
Compare
… to client options
a7e7707
to
d6e6231
Compare
In #2097 go-redis started to support passing a CredentialsProvider callback to get the username and password when initializing a connection, instead of having to provide them when creating the client. This is very useful in scenarios where you have these credentials stored in a separate service (e.g., AWS Secret Manager or Azure Key Vault) and you want to rotate those credentials periodically.
However, this option was not added in all clients and was not being passed down from the universal client to the concrete clients either. This PR aims to normalize that.
(Note that the CredentialsProviders field was already added to ClusterOptions in #2791, which is why they are not being touched in this change)