Make int_format_into API more flexible
#143636
Open
+92
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Maybe add some tests showing the error when the size was chosen wrong |
|
Oh right. Adding |
This comment was marked as outdated.
This comment was marked as outdated.
|
So sadly, I couldn't make the |
jieyouxu
reviewed
Jul 8, 2025
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
int_format_into-improvement
branch
from
5a05f0f to
25f59e2
Compare
GuillaumeGomez
force-pushed
the
int_format_into-improvement
branch
from
25f59e2 to
82d9d62
Compare
| /// | ||
| #[doc = concat!("let n = 32", stringify!($signed), ";")] | ||
| /// // We use a `NumBuffer` used to store a bigger integer. | ||
| /// let mut buf = NumBuffer::<u128>::new(); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
i128 and u128 are not covered by this macro, they are implemented below. So this example works all the time. :)
Also, if it didn't, the doctest would fail because compilation would fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #142098.
Part of #138215.
This change allows to pass
NumBuffer<u128>for any smaller integers, making the API much more flexible overall.r? @Amanieu