Skip to content

Add CMakePresets support #8739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Montel
Copy link
Contributor

@Montel Montel commented Jun 20, 2025

No description provided.

Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a presets file is a good thing to have in the repo. @hunger @ogoffart thoughts?

@ogoffart
Copy link
Member

I think a presets file is a good thing to have in the repo. @hunger @ogoffart thoughts?

What is the usecase? Is it to help people contributing to Slint?
In that case, I think it should include the flag that one usually would pass to work with Slint: CMAKE_EXPORT_COMPILE_COMMANDS, SLINT_BUILD_TESTING. Also release should probably be RelWithDebInfo

The extra .license file is a bit of noise and this information can be put in the REUSE.toml

@Montel
Copy link
Contributor Author

Montel commented Jun 27, 2025

I think a presets file is a good thing to have in the repo. @hunger @ogoffart thoughts?

What is the usecase? Is it to help people contributing to Slint? In that case, I think it should include the flag that one usually would pass to work with Slint: CMAKE_EXPORT_COMPILE_COMMANDS, SLINT_BUILD_TESTING. Also release should probably be RelWithDebInfo

The extra .license file is a bit of noise and this information can be put in the REUSE.toml

Yep it's mainly for helping people contributing to Slint.
I will add these variable too

@hunger
Copy link
Member

hunger commented Jul 1, 2025

I like this, it looks like a very sane CMake config to suggest :-)

Should we maybe go the full mile and suggest the skia backend? It has so much nicer fonts and all the tools to build skia should be available to somebody using CMake in the first place:-)

@tronical
Copy link
Member

tronical commented Jul 3, 2025

I'm not sure it's a good idea of the presets to override the feature defaults.

@Montel Montel force-pushed the add_cmakepresets branch from 6a825d5 to 59d6ecc Compare July 4, 2025 12:29
@Montel Montel force-pushed the add_cmakepresets branch from 494a02f to f2cf3a8 Compare July 4, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants