Skip to content

Only catch github API error #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2019
Merged

Only catch github API error #32

merged 2 commits into from
Dec 10, 2019

Conversation

pauleve
Copy link
Contributor

@pauleve pauleve commented Dec 10, 2019

Whenever supplying a non-existing file as body_path, the release method will retry indefinitely due the error thrown by releaseBody.
Catching errors only within createRelease call would correctly throw the error and terminate the script.

softprops
softprops approved these changes Dec 10, 2019
View reviewed changes
Copy link
Owner

@softprops softprops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@softprops softprops merged commit d651ef4 into softprops:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softprops softprops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauleve @softprops