Skip to content

fix: Update to latest throttling plugin #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2020
Merged

fix: Update to latest throttling plugin #53

merged 1 commit into from
May 25, 2020

Conversation

playpauseandstop
Copy link
Contributor

In attempt to fix unintentional retries on 422 error from GitHub,

  1. Update to latest @octokit/plugin-throttling version
  2. Depend on @octokit/plugin-retry plugin as well

Issue: #52


I found it hard to find any other way to fix the original issue, so decided to update to latest throttling plugin (with updating config key) & include retry plugin as well.

My findings based on probot/probot@1a19bdd

If this is not expected solution for original issue, I'll need a help in fixing it.

Thanks

In attempt to fix unintentional retries on 422 error from GitHub,

1. Update to latest `@octokit/plugin-throttling` version
2. Depend on `@octokit/plugin-retry` plugin as well

Issue: #52
@softprops
Copy link
Owner

I think this change is useful but it will likely not fix the 422 error. GitHub returns these for invalid input https://developer.github.com/v3/#client-errors. Retrying on invalid input will likely not make the request more likely to succeed.

I'll merge this and take a deeper look.

@softprops softprops merged commit 9439581 into softprops:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants