fix(main/mariadb): do not attempt to run a test binary during build if fmt is detected
#25130
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f `fmt` is detected - Progress on termux#23492 - Fixes this error in the command `scripts/run-docker.sh ./build-package.sh -I -f fmt mariadb`: ``` -- Performing Test HAVE_SYSTEM_LIBFMT CMake Error: try_run() invoked in cross-compiling mode, please set the following cache variables appropriately: HAVE_SYSTEM_LIBFMT_EXITCODE (advanced) For details see /home/builder/.termux-build/mariadb/build/TryRunResults.cmake -- Performing Test HAVE_SYSTEM_LIBFMT - Failed ``` - After this change, if `mariadb` happens to build while `fmt` is present in `$TERMUX_PREFIX`, - no error will happen at build-time, - and additionally, no dependency on `libfmt.so` will be added to any file in `mariadb`, - verified using the command `for f in $(dpkg -L mariadb); do ldd $f 2>/dev/null | grep fmt; done` [no ci]
|
I will merge it 24 hours from now if no problems are found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on Some packages cannot be built 3: Revenge of the Xiph #23492
Fixes this error in the command
scripts/run-docker.sh ./build-package.sh -I -f fmt mariadb:mariadbhappens to build whilefmtis present in$TERMUX_PREFIX,libfmt.sowill be added to any file inmariadb,for f in $(dpkg -L mariadb); do ldd $f 2>/dev/null | grep fmt; done