UnitTestFrameworkPkg: Make includes public #11176
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make private Include files public. UnitTestBootLib.h needs to be public to allow unit tests in other Pkg to use a UnitTestBootLib implementation, and also to allow for new implementations of this LibraryClass in other Pkg UnitTestResultReportLib.h needs to be public to allow unit tests in other Pkg to use a UnitTestResultReportLib implementation, or to allow for new implementations of this LibraryClass in other Pkg UnitTestFrameworkTypes.h needs to be public beause it is included by UnitTestResultReportLib.h Update UnitTestFrameworkPkg.dec to make public. Signed-off-by: Tim Hoppen <tim.hoppen@phoenixtech.com>
trhpx
force-pushed
the
UnitTestFrameworkPkg-make-includes-public
branch
from
c3e662d to
ae204ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make private Include files public.
UnitTestBootLib.h needs to be public to allow unit tests in other Pkg to use a UnitTestBootLib implementation, and also to allow for new implementations of this LibraryClass in other Pkg
UnitTestResultReportLib.h needs to be public to allow unit tests in other Pkg to use a UnitTestResultReportLib implementation, or to allow for new implementations of this LibraryClass in other Pkg
UnitTestFrameworkTypes.h needs to be public beause it is included by UnitTestResultReportLib.h
Update UnitTestFrameworkPkg.dec to make public.
Signed-off-by: Tim Hoppen tim.hoppen@phoenixtech.com
How This Was Tested
Build test of UnitTestFrameworkPkg\UnitTestFrameworkPkg.dsc
No other package is able to use the affected files (this is what the PR hopes to address), so no other package testing should be needed.
Integration Instructions
N/A