Skip to content

MdeModulePkg/UefiBootManagerLib: Fix crash when no load options are found #11177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

jbrasen
Copy link
Contributor

@jbrasen jbrasen commented Jun 10, 2025

Description

Fix crash when no load options are found
Do not attempt to sort the load options when there are none.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Validated API returns with no issues when no boot options are detected.

Integration Instructions

N/A

@jbrasen jbrasen force-pushed the Upstream/BootOrderSortAssert branch from 223093c to 64145e5 Compare June 18, 2025 15:27
@niruiyu niruiyu added the push Auto push patch series in PR if all checks pass label Jun 19, 2025
@lgao4
Copy link
Contributor

lgao4 commented Jun 23, 2025

@jbrasen , please fix CI failure. I think you need to remove change-id from the commit message.

@jbrasen jbrasen force-pushed the Upstream/BootOrderSortAssert branch from 64145e5 to 8180e64 Compare June 24, 2025 14:58
@jbrasen
Copy link
Contributor Author

jbrasen commented Jun 24, 2025

Fixed the commit message, forgot to disable the git hook

…ound

Do not attempt to sort the load options when there
are none.

Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
@leiflindholm leiflindholm force-pushed the Upstream/BootOrderSortAssert branch from 8180e64 to a6d0508 Compare June 25, 2025 11:59
@mergify mergify bot merged commit 0742590 into tianocore:master Jun 25, 2025
130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants