xe: softmax: correct src/dst scale in vectorized kernel #3451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:gpu-intel
pv-pterab-s
commented
Jun 19, 2025
atkassen
approved these changes
Jun 19, 2025
pv-pterab-s
force-pushed
the
pryorgal/softmax_reusable_scale_fix
branch
2 times, most recently
from
fd83dd8 to
82ff55d
Compare
h-sadia
reviewed
Jun 20, 2025
h-sadia
approved these changes
Jun 20, 2025
pv-pterab-s
force-pushed
the
pryorgal/softmax_reusable_scale_fix
branch
from
82ff55d to
3bf6078
Compare
echeresh
approved these changes
Jun 23, 2025
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects missing scale implementation in the vectorized version of the reusable softmax kernel. Adds explicit tests to check that the individual vectorized and "small" kernel implementations function.