Skip to content

formula: allow excluding deprecate! reason when disable! exists #18661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 30, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@cho-m cho-m mentioned this pull request Oct 30, 2024
7 tasks
@cho-m cho-m force-pushed the deprecate-disable-at-once branch from 5cb0d67 to c113c8e Compare October 30, 2024 03:01
@cho-m
Copy link
Member Author

cho-m commented Oct 30, 2024

For convenience, I've set @deprecation_reason even if before @deprecation_date. I don't think this should be an issue and information can be used on formulae page or by 3rd-party usage of API.

Otherwise, would have to deal with resetting the info to nil.

@p-linnane
Copy link
Member

This is a fantastic idea. Thanks @cho-m!

class Foo < Formula
url 'https://brew.sh/foo-1.0.tgz'
disable! date: "2021-08-28", because: :does_not_build
deprecate! date: "2020-08-28"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really relevant for this PR, but are these automatically sorted in this order by another cop? To me it would make more sense to have deprecate! sorted first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is from AST order:

[{ name: :disable!, type: :method_call }],
[{ name: :deprecate!, type: :method_call }],

Could reverse them if we wanted, though would need to make sure about handling. I did try to add code so order doesn't matter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look into order in #18974 prior to continuing this PR.

@cho-m cho-m added the in progress Maintainers are working on this label Nov 10, 2024
@cho-m
Copy link
Member Author

cho-m commented Nov 10, 2024

Will wait until after #18733 is merged to finish this up.

@Anki-code1
Copy link

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@Anki-code1
Copy link

Details

#18661 #20033 #20147 #20134
https://github.com/TypeStrong/typedoc.git @WillAR37

  • GITHUB-202410-GitHubDataProtectionAgreement.pdf

  • GITHUB-202410-GitHubDataProtectionAgreement.pdf

  • File size:

  • 206 KB (211,074 bytes)

  • Title: Got Project

  • TPL - 2024 10 - GitHub Data Protection Agreement

  • Author: William Drakus

  • T. Greg Doucette

Subject: GitHub Data Protection Agreement

#https://assets.ctfassets.net/8aevphvgewt8/DaflLjyuIt6un69xg3n6W/375560a9e93004190548b6c581b81ef3/GITHUB-202410-GitHubDataProtectionAgreement.pdf

Keywords: #Date #Github #SSH #DPA

Creation Date: (06-16-2025

12/20/24, 12:30:18 PM
Modification Date:

12/20/24, 12:30:18 PM
Creator: William E Drakus

Word
PDF Producer:

macOS Version 15.1.1 (Build 24B91) Quartz PDFContext
PDF Version:

1.3
Page Count:

23
Page Size:

8.5 × 11 in (Letter, portrait)
Fast Web View:

No
Style Syntax Keyboard shortcut Example Output
Bold ** ** or __ __ Command+B (Mac) or Ctrl+B (Windows/Linux) This is bold text This is bold text
Italic * * or _ _      Command+I (Mac) or Ctrl+I (Windows/Linux) This text is italicized This text is italicized
Strikethrough ~~ ~~ or ~ ~ None This was mistaken text This was mistaken text
Bold and nested italic ** ** and _ _ None This text is extremely important This text is extremely important
All bold and italic *** *** None All this text is important All this text is important
Subscript None This is a subscript text This is a subscript text
Superscript None This is a superscript text This is a superscript text
Underline None This is an underlined text This is an underlined text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Maintainers are working on this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants