Load formulae from the internal API with HOMEBREW_USE_INTERNAL_API
#20052
+123
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial pass at updating how we load Formulae to use the slimmed-down internal API, and fetch the remaining metadata from the OCI image. This is still a work-in-progress, but I wanted to open to get feedback on the approach.
One thing I definitely want to hear thoughts on:
How should we go about adding the JSON data to the OCI manifest files? Once this PR is merged, newly created bottles will have the additional data. For now, I've simply added a fallback for "if this fails, use
https://formulae.brew.sh/api/formula/wget.json
", but I don't think we should be relying on this method long-term, since I imagine many formulae won't get rebottled anytime soon.Is there a way to mass-update manifest files?