-
-
Notifications
You must be signed in to change notification settings - Fork 11k
Differentiate lesser used casks from formulae #217076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless it's just not showing up for me, I think adding the changes to cask_renames.json
is missing at the moment?
fa10a60
to
6517e96
Compare
Suggestion for merging:
|
6517e96
to
36e0f37
Compare
36e0f37
to
9c735ad
Compare
It might also make sense to update the corresponding entries in the |
@khipp I thought we'd switched over to the |
Happy to have it updated regardless, just unlikely to be able to personally before Monday so would ❤️ if folks could push whatever to this PR and help get it over the line. |
We did as well. I might just be overly cautious, since the last status was to revert if any issues arise. |
These are all casks that have formulae with the same name but the cask does not have substantially (>=2x) more usage in the last 365 days analytics data than the formula so the cask is being renamed.
Thanks all for help ❤️ |
@MikeMcQuaid It looks like these renamed casks are showing up twice in
I first noticed this because
How do we fix this, or remove the references to the old names? |
Looks like I fixed it by just deleting the symlinks with the old names in |
The symlinks are retained indefinitely for anyone who had the packages installed under the old name, to make sure any scripts etc.. continue working. I'm not sure the practicalities of skipping the symlinks for |
Not sure if this should be addressed in |
Homebrew cask name was updated in the following pull request: Homebrew/homebrew-cask#217076
Update cask name to reflect change in Homebrew/homebrew-cask#217076.
Update cask name to reflect change in Homebrew/homebrew-cask#217076.
Info was: ``` ==> Migrating cask docker to docker-desktop ==> Migrating cask fontforge to fontforge-app ==> Migrating cask wireshark to wireshark-app ==> Migrating cask xcodes to xcodes-app ``` Refs. - Homebrew/homebrew-cask@d20f5f8 - Homebrew/homebrew-cask#217076 - Homebrew/brew#20134
These are all casks that have formulae with the same name but the cask does not have substantially (>=2x) more usage in the last 365 days analytics data than the formula so the cask is being renamed.
See Homebrew/brew#20134
Part of Homebrew/brew#17560