Skip to content

Differentiate lesser used casks from formulae #217076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Conversation

MikeMcQuaid
Copy link
Member

These are all casks that have formulae with the same name but the cask does not have substantially (>=2x) more usage in the last 365 days analytics data than the formula so the cask is being renamed.

See Homebrew/brew#20134
Part of Homebrew/brew#17560

Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it's just not showing up for me, I think adding the changes to cask_renames.json is missing at the moment?

@MikeMcQuaid MikeMcQuaid force-pushed the token_conflicts branch 2 times, most recently from fa10a60 to 6517e96 Compare June 20, 2025 15:31
@MikeMcQuaid
Copy link
Member Author

Suggestion for merging:

  • review error messages to ensure none are specific to these changes
  • switch to syntax-only
  • merge PR

@MikeMcQuaid MikeMcQuaid added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jun 20, 2025
@khipp
Copy link
Member

khipp commented Jun 20, 2025

It might also make sense to update the corresponding entries in the autobump.txt file. That could be done in a follow-up PR, though.

@MikeMcQuaid
Copy link
Member Author

@khipp I thought we'd switched over to the no_autobump! DSL or is that just homebrew/core?

@MikeMcQuaid
Copy link
Member Author

Happy to have it updated regardless, just unlikely to be able to personally before Monday so would ❤️ if folks could push whatever to this PR and help get it over the line.

@MikeMcQuaid MikeMcQuaid requested a review from a team June 20, 2025 18:18
@khipp
Copy link
Member

khipp commented Jun 20, 2025

@khipp I thought we'd switched over to the no_autobump! DSL or is that just homebrew/core?

We did as well. I might just be overly cautious, since the last status was to revert if any issues arise.

These are all casks that have formulae with the same name but the cask
does not have substantially (>=2x) more usage in the last 365 days
analytics data than the formula so the cask is being renamed.
@khipp khipp force-pushed the token_conflicts branch from 8aa9df7 to d20f5f8 Compare June 21, 2025 14:09
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 23, 2025
Merged via the queue into master with commit 82b7c07 Jun 23, 2025
9 checks passed
@MikeMcQuaid MikeMcQuaid deleted the token_conflicts branch June 23, 2025 02:54
@MikeMcQuaid
Copy link
Member Author

Thanks all for help ❤️

martimlobao added a commit to martimlobao/dotfiles that referenced this pull request Jun 24, 2025
martimlobao added a commit to martimlobao/dotfiles that referenced this pull request Jun 24, 2025
@augmentedfourth
Copy link
Contributor

augmentedfourth commented Jul 1, 2025

@MikeMcQuaid It looks like these renamed casks are showing up twice in brew list now:

$ brew list --cask | egrep '^(wire|todo|scum)'
scummvm
scummvm-app
todoist
todoist-app
wireshark
wireshark-app

I first noticed this because buo/cask-upgrade was duplicating entries:

$ brew cu -a 2>&1 | egrep '(wire|todo|scum)'
Warning: Cask scummvm was renamed to scummvm-app.
Warning: Cask todoist was renamed to todoist-app.
Warning: Cask wireshark was renamed to wireshark-app.
22/38  scummvm-app              2.9.1            2.9.1             Y   [   OK   ]
23/38  scummvm-app              2.9.1            2.9.1             Y   [   OK   ]
31/38  todoist-app              9.17.0           9.17.0            Y   [   OK   ]
32/38  todoist-app              9.17.0           9.17.0            Y   [   OK   ]
36/38  wireshark-app            4.4.7            4.4.7             Y   [   OK   ]
37/38  wireshark-app            4.4.7            4.4.7             Y   [   OK   ]

How do we fix this, or remove the references to the old names?

@augmentedfourth
Copy link
Contributor

Looks like I fixed it by just deleting the symlinks with the old names in $HOMEBREW_PREFIX/Caskroom. I assume/hope that would've been cleaned up automatically at some point, but it's good now.

@bevanjkay
Copy link
Member

The symlinks are retained indefinitely for anyone who had the packages installed under the old name, to make sure any scripts etc.. continue working. I'm not sure the practicalities of skipping the symlinks for brew list, but it could be worth looking into.

@augmentedfourth
Copy link
Contributor

Not sure if this should be addressed in brew list or brew cu (or both), but I included an issue for the latter here.

dkav added a commit to dkav/macvim that referenced this pull request Jul 2, 2025
Homebrew cask name was updated in the following pull request: Homebrew/homebrew-cask#217076
dkav added a commit to dkav/homebrew-core that referenced this pull request Jul 2, 2025
Update cask name to reflect change in Homebrew/homebrew-cask#217076.
dkav added a commit to dkav/homebrew-core that referenced this pull request Jul 2, 2025
machupicchubeta added a commit to machupicchubeta/dotfiles that referenced this pull request Jul 6, 2025
Info was:
```
==> Migrating cask docker to docker-desktop
==> Migrating cask fontforge to fontforge-app
==> Migrating cask wireshark to wireshark-app
==> Migrating cask xcodes to xcodes-app
```

Refs.
- Homebrew/homebrew-cask@d20f5f8
- Homebrew/homebrew-cask#217076
- Homebrew/brew#20134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants